Moving primer-breadcrumbs to core #336
Conversation
|
Cool with this but thought I'd mention there is actually a breadcrumb pattern in the components directory 🙊 https://github.com/github/github/blob/master/app/assets/stylesheets/components/breadcrumb.scss - it's used on things like the blob editor. Basically looks the same but bigger.
We should consolidate those styles, and if we need both large and small then have modifier styles. |
I had a look and both of these (primer-breadcrumbs, and breadcrumbs.scss) need work. I don't want to hold up @imgonnarelph's product changes so I'm going to merge this and make note in https://github.com/github/design-systems/issues/248 |
Agreed! Our usage of the marketing breadcrumbs isn't as consistent as it could be. Happy to help with the refactor and/or combination of components. |
https://styleguide.github.com/primer/components/breadcrumb/ Breadcrumbs are useful for more than just marketing pages. I got a ping from @imgonnarelph asking about using the breadcrumbs on an updated team page. They're currently not available to non-
site.csspagesThis PR moves
primer-breadcrumbsfrom primer-marketing to primer-core so that it can be used in both product and marketing./cc @primer/ds-core